compliance/sancation_list_update_centralization #45
Conversation
mat-fs
force-pushed
the
compliance/sancation_list_update_centralization
branch
from
d28123d to
3db7903
Compare
| @@ -0,0 +1,230 @@ | |||
| package Data::Validate::Sanctions::Redis; | |||
There was a problem hiding this comment.
I would suggest naming it Data::Validate::Sanctions::Storage instead of Data::Validate::Sanctions::Redis. Redis is just a system that we are using, we may change this in future
There was a problem hiding this comment.
This module is exclusively created for redis storage. It relies on hmget and hmset calls and cannot be written without references to Redis. A better alternative IMHO is to use the parent class Data::Validate::Sactions as a Factory that can create an object of this subclass with a code like this:
my $validator = Data::Validate:::Sanctions->new(storage => 'redis`, connection => $redis);
…hub.com:mat-fs/perl-Data-Validate-Sanctions into compliance/sancation_list_update_centralization
.circleci/config.yml
Outdated
| - run: | ||
| name: Install Redis server | ||
| command: | | ||
| apt-get install -y redis && apt-get install -y redis-server |
There was a problem hiding this comment.
I guess you need install only redis-server
and if you want to install both , you can combine them:
| apt-get install -y redis && apt-get install -y redis-server | |
| apt-get install -y redis-server redis |
Changes
Outdated
| Revision history for Data-Validate-Sanctions | ||
|
|
||
| {{$NEXT}} | ||
| 0.14 2022-09-13 13:55:00 CST |
There was a problem hiding this comment.
This line can & should be removed. dzil release will add it automatically
| } | ||
|
|
||
| sub get_sanction_file { | ||
| $sanction_file //= _default_sanction_file(); |
There was a problem hiding this comment.
Will be better to use state here ?
There was a problem hiding this comment.
in some cases, the state declaration does not apply because we are using the internal scope of the variable in the set_sanction_file and the get_sanction_file subroutines.
6 participants
https://redmine.deriv.cloud/issues/70209